Conversation
Signed-off-by: Saurabh Sinha <[email protected]>
…analysis level 2 Signed-off-by: Saurabh Sinha <[email protected]>
Signed-off-by: Saurabh Sinha <[email protected]>
Cyclomatic complexity analysis level 1
Signed-off-by: Rahul Krishna <[email protected]>
Collaborator
Author
|
@fabio-franco please try to build and verify if the changes in this branch passes regression tests. |
Signed-off-by: Rahul Krishna <[email protected]>
Signed-off-by: Rahul Krishna <[email protected]>
sinha108
approved these changes
Jan 16, 2025
Signed-off-by: Rahul Krishna <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request add a static cyclomatic complexity computation (issue #91) and fixed the mangled comments in constructor declarations (issue #90)
Also addressed issues #88 and #87. There, I found that when executing Maven wrapper using its absolute path (
/path/to/codeanalyzer-failing-projects/portfolio-spring/mvnw), it was looking for just.mvn/wrapperfiles in the wrong working directory, causing aClassNotFoundException.I fixed this by splitting the absolute command path into directory and filename components. Now ProcessBuilder uses the command's parent directory as the working directory and the filename as the command.
I checked to make sure this applied to gradlew projects as well, and I made sure that the gradlew path is absolute.